Miscellaneous cleanup #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Feb 14, 2023
| @@ -488,7 +488,7 @@ public static void cloneFromScm( | |||
| * <li><code>git checkout FETCH_HEAD</code> | |||
| * </ul> | |||
| * | |||
| * @param gitURL The git native URL, see the <a | |||
| * @param gitUrl The git native URL, see the <a | |||
There was a problem hiding this comment.
This was not matching the case of the actual parameter.
| } | ||
| return moreInfo; |
There was a problem hiding this comment.
One-line code deduplication.
Comment on lines
+202
to
+203
| } catch (ReflectiveOperationException e) { | ||
| throw new RuntimeException("Error when loading " + c.getName(), e); |
There was a problem hiding this comment.
This should never happen, and if it does it is a serious error that would invalidate our confidence in the test run, so throw it up and halt execution.
| File pom = new File(rootDir.getAbsolutePath() + "/" + pomFileName); | ||
| Document doc; | ||
| try { | ||
| doc = new SAXReader().read(pom); | ||
| } catch (DocumentException x) { | ||
| throw new IOException(x); | ||
| throw new PomTransformationException("Failed to parse pom.xml", x); |
There was a problem hiding this comment.
Making this class consistent with the error handling philosophy elsewhere of failing fast and avoiding abuse of IOException.
imonteroperez
approved these changes
Feb 15, 2023
jtnord
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bunch of miscellaneous cleanup hunks that I've been collecting in a branch for a few weeks now. I tested these in BOM with
PLUGINS=text-finder bash local-test.sh.