Remove -testJDKHome argument
#444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Feb 7, 2023
| * | ||
| * @return a string identifying the jvm in use | ||
| */ | ||
| public String getTestJavaVersion() throws IOException { |
There was a problem hiding this comment.
Was only ever used to populate a value in an XML report that nobody ever looked at.
imonteroperez
approved these changes
Feb 7, 2023
jtnord
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be used by proprietary code but only seems to set the
jvmMaven property and I could not find any documentation regarding what that actually does. Regardless it seems cleaner to dispense with this option and just have consumers setJAVA_HOMEwhich is what themvncommand uses to determine which version of Java to run.