-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teach PCT about Mina SSHD API plugins #375
Conversation
/reviewer @jenkinsci/teams/plugin-compat-tester-developers |
/label enhancement |
/reviewer @jenkinsci/plugin-compat-tester-developers |
The bot has been turned off on most repos for now IIUC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design flaw in PCT that it even requires custom hooks for the routine case of a multimodule project, but in the meantime, we need this I guess.
One of many. 😀 |
Not familiar with the thing you are discussing unfortunately. I recall a problem being worked around in #318. |
Well I linked to the code. I am even less familiar than you. |
Discovered when running BOM/PCT tests with recent PCT bits in jenkinsci/bom#1059: although current BOM
master
builds appear fine with regard to the Mina SSHD API plugins, they are using an ancient and nonstandard version of PCT that fails to report many errors. Recent and unmodified PCT bits show errors like the ones from this run (specific log formina-sshd-api-core
) andpct-report.xml
contains<status>INTERNAL_ERROR</status>
.This PR corrects the specific problem shown above by teaching PCT about the Mina SSHD API plugins, and I tested it in this run (see the corresponding build log for
mina-sshd-api-core
). The build progresses further than before (as demonstrated by comparing the two build logs formina-sshd-api-core
), although ultimately the tests formina-sshd-api-core
still do not get executed: unlike e.g.pipeline-stage-view
(which triggers this code path, which works), the Mina SSHD API plugins are in a multi-module Maven project with JEP-229 enabled (which triggers this code path, skipping all tests because they are apparently not supported in multimodule Maven projects with JEP-229 enabled). I filed any latent curiousity about this gap in feature parity between JEP-229 and non-JEP-229 plugins for another day and decided to proceed with the current PR which at least improves the status quo. Besides, this PR is completely risk-free for anything other than the Mina SSHD API plugins, so merging it cannot hurt. And most importantly, it is the last thing standing in my way to completing jenkinsci/bom#1059.