Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove broken powermock test (fix mainline) #342

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Remove broken powermock test (fix mainline) #342

merged 1 commit into from
Jan 28, 2022

Conversation

timja
Copy link
Member

@timja timja commented Jan 27, 2022

Test blows up early on in Java 11

Failing on master branch with Java 8 too

https://ci.jenkins.io/blue/organizations/jenkins/jenkinsci-libraries%2Fplugin-compat-tester/detail/master/179/tests

@timja timja added the chore label Jan 27, 2022
@jglick jglick added test and removed chore labels Jan 27, 2022
jglick
jglick approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing PowerMock 👍

Did you see a straightforward way of converting this to a simple unit test? Factoring some impl out into a static method?

@timja
Copy link
Member Author

timja commented Jan 27, 2022

Removing PowerMock 👍

Did you see a straightforward way of converting this to a simple unit test? Factoring some impl out into a static method?

tbh didn't look much, too tired right now.

@imonteroperez imonteroperez merged commit 8e47233 into jenkinsci:master Jan 28, 2022
@timja timja deleted the fix-main-build branch January 28, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@imonteroperez imonteroperez imonteroperez approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timja @jglick @imonteroperez