Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structs plugin has been flatten for versions higher than 1.24 #334

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

raul-arabaolaza
Copy link
Contributor

Now the hook is not needed, but I will keep it for the moment for backwards compatibility in case some security backport is needed

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Now the hook is not needed, but I will keep it for the moment for backwards
compatibility in case some security backport is needed
@jglick
Copy link
Member

jglick commented Jan 4, 2022

Maybe we can find some way to detect multimodule repos automatically? It is really awkward to have to hard-code support for every such case in PCT.

Even better, collect all the plugins built out of a given repo and test them all at once via e.g. mvn surefire:test at top level, rather than trying to build and test individual reactor modules which makes for complications like #318.

@raul-arabaolaza
Copy link
Contributor Author

Maybe we can find some way to detect multimodule repos automatically? It is really awkward to have to hard-code support for every such case in PCT.

Even better, collect all the plugins built out of a given repo and test them all at once via e.g. mvn surefire:test at top level, rather than trying to build and test individual reactor modules which makes for complications like #318.

@cathychan @imonteroperez I believe this lands on your team?

@cathychan
Copy link
Contributor

@cathychan @imonteroperez I believe this lands on your team?

Ack. Created a ticket on our board.

…k/StructsHook.java

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@raul-arabaolaza
Copy link
Contributor Author

All tests are passing for me locally and the error is always a timeout trying to reach the jenkins update center, I am dismissing them as unrelated and caused by a temp hiccup in the jenkins infra.

@raul-arabaolaza raul-arabaolaza merged commit 53a1353 into jenkinsci:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants