-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structs plugin has been flatten for versions higher than 1.24 #334
Structs plugin has been flatten for versions higher than 1.24 #334
Conversation
Now the hook is not needed, but I will keep it for the moment for backwards compatibility in case some security backport is needed
plugins-compat-tester/src/main/java/org/jenkins/tools/test/hook/StructsHook.java
Outdated
Show resolved
Hide resolved
Maybe we can find some way to detect multimodule repos automatically? It is really awkward to have to hard-code support for every such case in PCT. Even better, collect all the plugins built out of a given repo and test them all at once via e.g. |
@cathychan @imonteroperez I believe this lands on your team? |
…k/StructsHook.java
plugins-compat-tester/src/main/java/org/jenkins/tools/test/hook/StructsHook.java
Outdated
Show resolved
Hide resolved
Ack. Created a ticket on our board. |
…k/StructsHook.java Co-authored-by: Jesse Glick <jglick@cloudbees.com>
All tests are passing for me locally and the error is always a timeout trying to reach the jenkins update center, I am dismissing them as unrelated and caused by a temp hiccup in the jenkins infra. |
Now the hook is not needed, but I will keep it for the moment for backwards compatibility in case some security backport is needed