Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove adhoc dependency replacement for maven-plugin #312

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Remove adhoc dependency replacement for maven-plugin #312

merged 1 commit into from
Oct 20, 2021

Conversation

imonteroperez
Copy link
Contributor

@imonteroperez imonteroperez commented Oct 19, 2021 •
edited
Loading

Highlights

  • It tries to remove adhoc dependency replacement for maven-plugin from: f6cc140
  • It seems not needed anymore and it is making some invalid dependency version replacement

Tasks

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@imonteroperez imonteroperez self-assigned this Oct 19, 2021
jglick
jglick approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have been pretty old—predating split of maven-plugin from core.

@imonteroperez imonteroperez marked this pull request as ready for review October 20, 2021 07:58
@imonteroperez imonteroperez merged commit 60f9091 into jenkinsci:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@raul-arabaolaza raul-arabaolaza raul-arabaolaza approved these changes

Assignees

@imonteroperez imonteroperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imonteroperez @jglick @raul-arabaolaza