Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for actual failure or error nodes on testcase #286

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

jlamasrios
Copy link
Contributor

rather than assuming the presence of any child node not named "skipped" is a failure.
Related to JENKINS-66165.

The code was assuming that testcase nodes for successful tests have no child nodes, and was only considering the case for skipped ones. However, test results may actually include system-out and system-err child nodes, for instance, and that shouldn't be taken as indicative of failure.

The old code happened to work ok because successful cases usually come with no child nodes, but that may not always work. Checking for explicit "failure" or "error" elements seems a more appropriate implementation.

This PR fixes JENKINS-66165.

The error can be reproduced by using PCT for genexus plugin on its currently last released version 1.11

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

rather than assuming the presence of any child node not named "skipped" is a failure.
Related to JENKINS-66165.
Copy link
Contributor

@imonteroperez imonteroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raul-arabaolaza raul-arabaolaza merged commit 6eced5c into jenkinsci:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants