Check for actual failure or error nodes on testcase #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than assuming the presence of any child node not named "skipped" is a failure.
Related to JENKINS-66165.
The code was assuming that testcase nodes for successful tests have no child nodes, and was only considering the case for skipped ones. However, test results may actually include system-out and system-err child nodes, for instance, and that shouldn't be taken as indicative of failure.
The old code happened to work ok because successful cases usually come with no child nodes, but that may not always work. Checking for explicit "failure" or "error" elements seems a more appropriate implementation.
This PR fixes JENKINS-66165.
The error can be reproduced by using PCT for genexus plugin on its currently last released version 1.11