Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Hooks for Warnings NG #249

Merged

Conversation

fcojfernandez
Copy link
Contributor

@fcojfernandez fcojfernandez commented Aug 3, 2020

PR to make Warnings NG Plugin executable on PCT:

  • BeforeCheckoutHook since the plugin is multimodule
    • The Hook expects the same folder structure as in the repository
    • The plugin directory is the plugin folder
    • Hook allows the localcheckoutDir option
  • BeforeExecutionHook since the plugin includes integration tests
    • New parent class for other plugins to be used
    • Hook for the Warnings NG Plugin itself

@bmunozm @raul-arabaolaza @imonteroperez

CC @uhafner fyi as maintainer of the Warnings NG Plugin

@raul-arabaolaza
Copy link
Contributor

@fcojfernandez Code LGTM, and build failure looks like a infra issue, closing and reopening to trigger build again

@fcojfernandez
Copy link
Contributor Author

The CI is not re-launched. Closing again ...

@fcojfernandez fcojfernandez reopened this Aug 5, 2020
@raul-arabaolaza raul-arabaolaza merged commit 9b7f03b into jenkinsci:master Aug 5, 2020
@fcojfernandez fcojfernandez deleted the warnings-ng-compatible branch August 5, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants