Add hook for sse-gateway and workflow-cps for node and node_modules issue #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some Jenkins plugins end up with
node
andnode_modules
directories in their local source directories after compilation. With standard builds this is fine, and it's fine with many ways of running the PCT. However, when the PCT's-localCheckoutDir
is used, such plugins can fail with difficult to understand errors fromgulp
.This PR is a hook, much like the existing ones, which works past this problem specifically for sse-gateway and workflow-cps. Following below is some example output of running the PCT against master of workflow-cps.
The issue can also be recreated with sse-gateway, with the results being slightly different. With sse-gateway, the "fixed" PCT run shows a different failure, which would be fixed if I file a PR with this simple change to that plugin. I actually read about that here. Without my change, sse-gateway fails with an identical
Error: Cannot find module '../lib/completion'
error to the one from workflow-cps.Example output, before and after this PR
Without this PR:
With this PR: