Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test name solver bug for multi-module projects #241

Merged
merged 1 commit into from
May 13, 2020

Conversation

imonteroperez
Copy link
Contributor

  • When running PCT for single Maven project Jenkins plugins, surefire-reports used to be on <base-directory-folder>/target but if you run it for multimodule Maven projects it probably will not be able to locate properly where are the surefire-reports.
  • Before this PR when we do something like:
java -jar plugins-compat-tester-cli/target/plugins-compat-tester-cli.jar \
[...] 
-includePlugins configuration-as-code 
-mavenProperties test=SecretSourceResolverTest \

We get the following result:

[INFO] -------------------------------------------------------
[INFO] Solving test names
[INFO] -------------------------------------------------------
[WARNING] Unable to retrieve info from: /tmp/pct/work/configuration-as-code/target/surefire-reports
org.jenkins.tools.test.exception.PomExecutionException: [/usr/bin/mvn, --show-version, --batch-mode, -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn, --define=failIfNoTests=false, --define=forkCount=1, hpi:resolve-test-dependencies, hpi:test-hpl, surefire:test, -Djenkins.version=2.222.1-cb-7, -Denforcer.skip=true] failed in /tmp/pct/work/configuration-as-code
	at org.jenkins.tools.test.maven.ExternalMavenRunner.run(ExternalMavenRunner.java:103)
	at org.jenkins.tools.test.PluginCompatTester.testPluginAgainst(PluginCompatTester.java:554)
	at org.jenkins.tools.test.PluginCompatTester.testPlugins(PluginCompatTester.java:314)
	at org.jenkins.tools.test.PluginCompatTesterCli.main(PluginCompatTesterCli.java:175)

Because configuration-as-code is a multi-module Maven project: https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/pom.xml#L15..L19

  • After this PR we will obtain the following result:
[INFO] -------------------------------------------------------
[INFO] Solving test names
[INFO] -------------------------------------------------------
[INFO] Reading /tmp/pct/work/configuration-as-code/plugin/target/surefire-reports
[INFO] Extracted 25 testnames from /tmp/pct/work/configuration-as-code/plugin/target/surefire-reports/TEST-io.jenkins.plugins.casc.SecretSourceResolverTest.xml
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Executed: 25
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_defaultValueLimit
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_emptyDefault
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_emptyDefaultEnvDefined
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_mixedMultipleEntries
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_mixedMultipleEntriesEscaped
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_mixedMultipleEntriesWithDefault
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_mixedSingleEntry
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_mixedSingleEntryEscaped
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_mixedSingleEntryWithDefault
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_multipleEntries
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_multipleEntriesEscaped
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_multipleEntriesWithDefaultValue
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_multipleEntriesWithDefaultValueAndEnvDefined
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_multipleEntriesWithoutDefaultValue
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_nothing
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_nothingBrackets
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_nothingDefault
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_nothingSpace
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_singleEntry
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_singleEntryDoubleEscaped
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_singleEntryEscaped
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_singleEntryWithDefaultValue
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_singleEntryWithDefaultValueAndWithEnvDefined
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.resolve_singleEntryWithoutDefaultValue
[INFO] - io.jenkins.plugins.casc.SecretSourceResolverTest.shouldEncodeInternalVarsProperly
[INFO] 
[INFO] Failed: 0

@raul-arabaolaza
Copy link
Contributor

PR errors are not related, merging

@raul-arabaolaza raul-arabaolaza merged commit fc69a4d into jenkinsci:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants