Include Docker client executable in the PCT Docker image #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raul-arabaolaza
previously requested changes
Nov 20, 2019
|
|
||
| RUN curl -L --show-error https://download.java.net/java/GA/jdk11/13/GPL/openjdk-11.0.1_linux-x64_bin.tar.gz --output openjdk.tar.gz && \ | ||
| echo "7a6bb980b9c91c478421f865087ad2d69086a0583aeeb9e69204785e8e97dcfd openjdk.tar.gz" | sha256sum -c && \ | ||
| tar xvzf openjdk.tar.gz && \ | ||
| mv jdk-11.0.1/ /usr/lib/jvm/java-11-openjdk-amd64 && \ | ||
| rm openjdk.tar.gz | ||
|
|
||
| RUN curl -fsSL https://download.docker.com/linux/debian/gpg | apt-key add - |
There was a problem hiding this comment.
If you move this before line 48 you can use the apt call in line 48 to prevent calling apt twice
There was a problem hiding this comment.
It is not possible as you need first install the packages to be able to add properly the repository
oleg-nenashev
changed the title
oleg-nenashev
approved these changes
Dec 24, 2019
oleg-nenashev
changed the title
oleg-nenashev
dismissed
raul-arabaolaza’s stale review
comments were addressed
|
CasC is a known issue, going to merge the current PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing PCT for new version 1.33 for the durable-task plugin, we need to have docker installed in the PCT docker image to make test can run properly
cc/ @oleg-nenashev @dwnusbaum @raul-arabaolaza @batmat