Update parent POM from 1.50 to 1.52

[basil]

Supercedes #195. Fixes the error from that PR …

+-org.jenkins-ci.tests:plugins-compat-tester-model:0.2.1-SNAPSHOT
  +-org.reflections:reflections:0.9.10
    +-com.google.code.findbugs:annotations:2.0.1
and
+-org.jenkins-ci.tests:plugins-compat-tester-model:0.2.1-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:1.625.3
    +-org.jenkins-ci:version-number:1.6 (managed) <-- org.jenkins-ci:version-number:1.1
      +-com.google.code.findbugs:annotations:3.0.0

… by adding a dependencyManagement section and choosing the higher version.

[oleg-nenashev]

Should be moved to SpotBugs annotations later.

Is it a Hacktoberfest pull request just in case? Just to label it properly on our side. See Hacktoberfest in Jenkins. If you do not participate in it, please consider doing so. Your pull requests are much appreciated 👍

[basil]

Should be moved to SpotBugs annotations later.

As far as I can tell, plugin-compat-tester isn't directly consuming FindBugs in any way. The Enforcer conflict came from org.reflections:reflections:0.9.10 (see #125) and org.jenkins-ci:version-number:1.6. I'll look into updating the POM for version-number and getting it onto SpotBugs.

Is it a Hacktoberfest pull request just in case? Just to label it properly on our side. See Hacktoberfest in Jenkins. If you do not participate in it, please consider doing so. Your pull requests are much appreciated +1

I wasn't aware of @jenkinsci/hacktoberfest, but sure, why not. I just signed up.

[oleg-nenashev]

I will try to merge it ASAP. The thing is that I screwed up the 0.3.0 release and cut it from the wrong branch, so no I need to do some fixes in the repo

…

On Fri, Oct 11, 2019 at 6:27 PM Basil Crow ***@***.***> wrote: Should be moved to SpotBugs annotations later. As far as I can tell, plugin-compat-tester isn't directly consuming FindBugs in any way. The Enforcer conflict came from org.reflections:reflections:0.9.10 (see #125 <#125>) and org.jenkins-ci:version-number:1.6. I'll look into updating the POM for version-number and getting it onto SpotBugs. Is it a Hacktoberfest pull request just in case? Just to label it properly on our side. See Hacktoberfest in Jenkins <https://jenkins.io/events/hacktoberfest>. If you do not participate in it, please consider doing so. Your pull requests are much appreciated +1 I wasn't aware of @jenkinsci/hacktoberfest <https://github.com/orgs/jenkinsci/teams/hacktoberfest>, but sure, why not. I just signed up. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#201?email_source=notifications&email_token=AAW4RIFLCJ4MP3LTGDH5MWTQOCSO3A5CNFSM4I5VZBUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAQPRY#issuecomment-541132743>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAW4RIEDNTIVSOY5ZZLXB6TQOCSO3ANCNFSM4I5VZBUA> .