Add Swarm Plugin support to PCT #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Sep 11, 2019
| @@ -85,7 +85,7 @@ public void validate(Map<String, Object> toCheck) throws Exception { | |||
| @Override | |||
| public boolean check(Map<String, Object> info) throws Exception { | |||
| return BlueOceanHook.isBOPlugin(info) || DeclarativePipelineHook.isDPPlugin(info) || StructsHook.isStructsPlugin(info) || | |||
| ConfigurationAsCodeHook.isCascPlugin(info) || PipelineRestApiHook.isPipelineStageViewPlugin(info); | |||
| SwarmHook.isSwarmPlugin(info) || ConfigurationAsCodeHook.isCascPlugin(info) || PipelineRestApiHook.isPipelineStageViewPlugin(info); | |||
There was a problem hiding this comment.
We should finally rewrite the hook engine at some point to an extension-alike approach.
This line makes me cry :D
There was a problem hiding this comment.
Agreed, this would be a good area for future improvement.
| @@ -58,7 +59,7 @@ public boolean check(Map<String, Object> info) { | |||
| boolean coreRequiresNewParentPOM = coreCoordinates.compareVersionTo(CORE_NEW_PARENT_POM) >= 0; | |||
| boolean coreRequiresPluginOver233 = coreCoordinates.compareVersionTo(CORE_WITHOUT_WAR_FOR_TEST) >= 0; | |||
|
|
|||
| if (isDeclarativePipeline || isBO || isCB || isStructs || isCasC || isPipelineStageViewPlugin || (pluginPOM && parentV2)) { | |||
| if (isDeclarativePipeline || isBO || isCB || isStructs || isCasC || isPipelineStageViewPlugin || isSwarm || (pluginPOM && parentV2)) { | |||
oleg-nenashev
changed the title
|
Thanks @basil ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Swarm support to PCT following the existing examples for Pipeline: Delarative, Pipeline: REST API, and Structs.
First, I added a new
SwarmHookclass with the details of the Swarm plugin's structure. Then, I updatedMultiParentCompileHookandTransformPomto add references toSwarmHookfollowing the existing examples.I added an integration test in
src/it/war-with-plugins-test/packager-config.yml, but I'm not sure how to run it. I tested PCT against Swarm locally in the BOM project before and after this change. Before, it failed; after, it passed.