[JENKINS-58051] Hook for plugins not using standard tags #159
Conversation
There was a problem hiding this comment.
we had a chat converstation with @raul-arabaolaza , and the agreement was that there would be integration tests for this PR. Requesting changes just to reflect this agreement
Thanks for the PR in any case, it should be really helpful for some releases
|
@oleg-nenashev @batmat added Unit and IT tests |
|
Legitimate test failure in windows, fixing it. |
|
And fixed and ready for review |
There was a problem hiding this comment.
Maybe the maximumVersion is also or even more interesting, WDYT @raul-arabaolaza ?
| @@ -0,0 +1,2 @@ | |||
| electricflow=cloudbees-flow-%s | |||
| electricflow-minimumVersion=1.1.8 | |||
There was a problem hiding this comment.
Is not more interesting to have the maximunVersion? If a plugin changes, it is to become compliant with the rules, so the latest versions most likely, don't need the hook anymore. Or maybe both properties. WDYT?
BTW: I was working in exactly the same hook but specifically in a job on our CI, so 💯
JENKINS-58051 This PR introduces a hook that can be extended trivially by plugins not following the standard tag conventions in Jenkins to make the PCT able to checkout them from Github