Add a flag to disable local install of artifacts #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 2.3 to 3.2.1. - [Release notes](https://github.com/apache/maven-shade-plugin/releases) - [Commits](apache/maven-shade-plugin@maven-shade-plugin-2.3...maven-shade-plugin-3.2.1) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps ant from 1.9.2 to 1.10.5. Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps appengine-api-1.0-sdk from 1.5.5 to 1.9.73. Signed-off-by: dependabot[bot] <support@dependabot.com>
So, I have everything already prepared on my host local repository, I usually run the docker image sharing my host local maven repo to speed things up. On those circumstances installing locally only serves to make the run slower.
oleg-nenashev
requested changes
May 17, 2019
There was a problem hiding this comment.
Thanks @raul-arabaolaza ! An opt-out approach looks good to me
Why do I request a change? I suggest following the same variable pattern as before, hence uppercase. Also, the flag should be reflected in the documentation.
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
|
I will update the doc |
oleg-nenashev
requested changes
May 22, 2019
…-tester into LOCAL_FLAG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are working with snapshots (for example when doing local development) the
run-pctscript tries to install artifacts from the war file to make sure they are available for local runs. However, that could not work when using custom generated war files and is unneeded if you share somehow your local maven repo with all the needed artifacts already there (I use that approach every day)So, this PR introduces a flag to prevent that local installation to happen if desired