[JENKINS-56312] Prevent adding splits with the wrong JDK #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ops, this is a mistake... fixing my PR now, is not going to be much bigger :P |
raul-arabaolaza
force-pushed
the
JENKINS-56312
branch
from
a7a959d
to
fca59b1
Compare
|
@Wadeck Now you can review, as promised not much bigger :) |
bmunozm
approved these changes
Feb 27, 2019
Wadeck
approved these changes
Feb 28, 2019
oleg-nenashev
requested changes
Feb 28, 2019
plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
Outdated
Show resolved
Hide resolved
plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
Outdated
Show resolved
Hide resolved
alecharp
suggested changes
Feb 28, 2019
There was a problem hiding this comment.
I agree with @oleg-nenashev about the Java version comparison.
Co-Authored-By: raul-arabaolaza <raul.arabaolaza@gmail.com>
Exactly :) |
bmunozm
approved these changes
Feb 28, 2019
oleg-nenashev
approved these changes
Feb 28, 2019
plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-56312 Only add splits with JDK field if testJDK is newer than the specified JDK version.
This is the first of two fixes to prevent failures related to the PCT adding
jaxbplugin to builds outside of java 11, second one will make sure the addedjaxbdependency uses the proper groupId instead oforg.jenkins-ci.plugins