--local-checkout-dir runs tests twice for plugins in the war

[jtnord]

Jenkins and plugins versions report

Environment

Paste the output here

What Operating System are you using (both controller, and any agents involved in the problem)?

all

Reproduction steps

• create a war which includes a plugin (e.g. warnings-ng)
• clone the sources for the plugin to a local directory
• run the pct and specify the local checkout directory (java -jar target\plugins-compat-tester-cli.jar test-plugins --war mywar.war` --working-dir=C:\workarea\temp\ --include-plugins=warnings-ng --local-checkout-dir=C:\workarea\source\github\jenkinsci\warnings-ng-plugin\

Expected Results

the tests for warnings-ng are only run from the local checkout

Actual Results

tests are run for both the version of warnings-ng in the war and the version in the local clone

Anything else?

I introduced this issue in #510, previously the behaviour was defined if you provided a single plugin id to be included in the command line, but did not work for multi-module checkouts.

I expect using --local-checkout-dir to use that checkout for the list of plugins to test, and ignore anything plugins in the war, as I expect this to be used mainly by developers either
a) trying to validate a fix to an issue is working (or even reproduce a specific issue)
b) test a plugin that is not in the war

[jtnord]

IIUC neither the OSS BOM automation nor CloudBees' automation relies on testing plugins that are both included in the war and provided as a local checkout at the same time.

So I intend to change the behviour so that if you specify --local-checkout-dir then only plugins that are in the directory specified will be located for testing (ignoring any plugins in the war.