Do not warn when triggered job is a success

[hashar]

I keep having log messages such as:

WARNING: [hudson.plugins.parameterizedtrigger.TriggerBuilder perform]
Attempting to use the result of unfinished build #1234

The message was introduced in #161 by 06d8f19 but in #148 / 02ee6ea, mapBuildResult() was made to return null by default (eg on SUCCESS).

The resut is the warning is always triggered when the triggered build succeeds.

Fixes https://phabricator.wikimedia.org/T336782

Testing done

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

This pull request is a good reason to release a new version of the plugin, though I would like to complete the evaluation of the upgrade of the optional dependency on promoted builds plugin before this is released. The optional dependency is being evaluated in pull requests:

• Bump promoted-builds optional dependency to 892.vd6219fc0a_efb #378
• Test parameterized trigger optional dependency update bom#3172
• Bump org.jenkins-ci.plugins:promoted-builds from 3.11 to 940.va_9b_59a_717a_b_1 #367

My preference is to update to the older version of promoted builds so that the fewest users are forced to update to a newer version of promoted builds, but the dependency version is still modernized to a popular release that is only 20 months old instead of 29 months old.

[MarkEWaite]

Tests pass in plugin BOM draft pull request when the optional dependency on promoted builds plugin is updated to the same new value in both the git plugin and the parameterized trigger plugin. That means we'll need a release of git plugin and a release of parameterized trigger plugin in the same plugin BOM release.

This pull request will be the catalyst for the automated release of the parameterized trigger plugin.

[hashar]

Do you need me to rebase the pull request?

[MarkEWaite]

Thanks for asking, but no need to rebase. It will be squash merged

[hashar]

Thank you for the release. I have confirmed the warnings are gone!