Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use automated code formatting #370

Merged
merged 11 commits into from
Mar 2, 2024
Merged

Conversation

shivajee98
Copy link
Contributor

Apply Code Formatting

This commit addresses code formatting inconsistencies in the parameterized-trigger-plugin.
The changes were made using the mvn spotless:apply command, which automatically enforces the project's coding standards.

Changes include insertions and deletions to ensure a consistent and readable codebase. The formatting adjustments do not impact the functionality of the plugin.

Details:

  • Ran mvn spotless:apply to enforce coding standards
  • Inspected and reviewed changes for adherence to project guidelines
  • No functional modifications; changes focus solely on code formatting

Testing done

Testing done locally on ubuntu 23.10

Submitter checklist

@shivajee98 shivajee98 requested a review from a team as a code owner January 27, 2024 17:10
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. One item needs to be addressed.

pom.xml Show resolved Hide resolved
Fix formatting errors in the contributing file
@MarkEWaite MarkEWaite changed the title [parameterized-trigger-plugin] Apply Code formatting Use automated code formatting Feb 18, 2024
@MarkEWaite MarkEWaite enabled auto-merge (squash) March 2, 2024 07:30
@MarkEWaite MarkEWaite disabled auto-merge March 2, 2024 07:34
@MarkEWaite
Copy link
Contributor

@shivajee98 there was a code change hidden in the formatting. That's a bad thing to when your pull request description says that there are no code changes in the pull request. Luckily, I found the code changes by running the formatting step myself. I've reverted the source code changes but retained the changes in the contributing guide because they fix a bug in the earlier contributing guide and tell contributors how to use code formatting and spotbugs.

@MarkEWaite MarkEWaite enabled auto-merge (squash) March 2, 2024 07:46
@MarkEWaite MarkEWaite merged commit f8bfe01 into jenkinsci:master Mar 2, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants