Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a banner to RH/deb pages about GPG key changes #379

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Add a banner to RH/deb pages about GPG key changes #379

merged 3 commits into from
Mar 28, 2023

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault requested a review from a team as a code owner March 27, 2023 14:58
dduportal
dduportal reviewed Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking proposal to materialize there is a new key version.

Also, we might want to add at least the new link if it is ok for you?

Something like this (as per the code below):

{{web_url}}/{{organization}}-2023.key

@NotMyFault
Copy link
Member Author

Non blocking proposal to materialize there is a new key version.

Oic, I didn't check out the puppet PR yet. Nice idea with the version suffix.

@MarkEWaite
Copy link
Contributor

I assume that we can make this visible as soon as https://pkg.jenkins.io/debian/jenkins.io-2023.key and friends are visible to users. Tuesday morning European time seems soon enough to me.

@NotMyFault NotMyFault merged commit 5bd63d7 into jenkinsci:master Mar 28, 2023
@NotMyFault NotMyFault deleted the gpg-banner branch March 28, 2023 08:22
NotMyFault added a commit to NotMyFault/packaging that referenced this pull request Mar 28, 2023
@NotMyFault
Add a banner to RH/deb pages about GPG key changes (jenkinsci#379)
40e4a37 
* Add a banner to RH/deb pages about GPG key changes

* Address review feedback

* Fill in blog post URL

(cherry picked from commit 5bd63d7)
@NotMyFault NotMyFault mentioned this pull request Mar 28, 2023
Merged
NotMyFault added a commit that referenced this pull request Mar 28, 2023
@NotMyFault
Backport gpg key banner to stable branches (#381)
5039322 
Add a banner to RH/deb pages about GPG key changes (#379)

* Add a banner to RH/deb pages about GPG key changes

* Address review feedback

* Fill in blog post URL

(cherry picked from commit 5bd63d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@timja timja Awaiting requested review from timja

@dduportal dduportal Awaiting requested review from dduportal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotMyFault @MarkEWaite @dduportal