Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expires can be 0 so manage this case (easily for now) #212

Merged
merged 2 commits into from
May 3, 2023

Conversation

olamy
Copy link
Member

@olamy olamy commented Mar 22, 2023

See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expires

The PR is just looking at the 0 value for the header but doesn't look at values of Cache-Control.
If you think it's needed let me know and I can add it but due to the nature of such file I found this a bit complicated for no real added value.

Signed-off-by: Olivier Lamy olamy@apache.org

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
@michael-doubez michael-doubez merged commit c543a86 into jenkinsci:master May 3, 2023
@michael-doubez michael-doubez added this to the 2.6 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants