expires can be 0 so manage this case (easily for now) #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expires
The PR is just looking at the 0 value for the header but doesn't look at values of Cache-Control.
If you think it's needed let me know and I can add it but due to the nature of such file I found this a bit complicated for no real added value.
Signed-off-by: Olivier Lamy olamy@apache.org