Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to enable PKCE #191

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

michael-doubez
Copy link
Contributor

@michael-doubez michael-doubez commented Jan 5, 2023

Add pkceEnabled configuration option to enable PKCE challenge. Note that google library doesn't allow to configure the verification method: it uses S256 if possible and then fallback to plain.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@michael-doubez michael-doubez self-assigned this Jan 5, 2023
@michael-doubez michael-doubez linked an issue Jan 5, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #191 (526a646) into master (8bebdeb) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #191      +/-   ##
============================================
+ Coverage     72.94%   73.18%   +0.24%     
- Complexity      174      177       +3     
============================================
  Files             9        9              
  Lines           669      675       +6     
  Branches        106      107       +1     
============================================
+ Hits            488      494       +6     
  Misses          130      130              
  Partials         51       51              
Impacted Files Coverage Δ
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 69.71% <100.00%> (+0.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PKCE Support
1 participant