Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin linking of mojohouse plugins in executed mojo overview, address dead URLs and minor http -> https cleanup #239

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

NotMyFault
Copy link
Member

If you're using maven plugins from mojohouse, formerly known as mojo@codehouse, the redirection links to a dead URL.
I've fixed the linking to the new domain and additionally enforced https calls for plugin redirections.
Additionally I addressed http calls and deprecated html tags in the documentation as well.

cc @olamy for review

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@olamy
Copy link
Member

olamy commented Dec 29, 2021

@NotMyFault can you please update the title of this PR because it contains more fixes than mojohaus url change

@NotMyFault NotMyFault changed the title fix: Fix plugin linking in executed mojo overview Fix plugin linking of mojohouse plugins in executed mojo overview and address dead URLs Dec 29, 2021
@NotMyFault NotMyFault changed the title Fix plugin linking of mojohouse plugins in executed mojo overview and address dead URLs Fix plugin linking of mojohouse plugins in executed mojo overview, address dead URLs and minor http -> https cleanup Dec 29, 2021
@NotMyFault
Copy link
Member Author

@NotMyFault can you please update the title of this PR because it contains more fixes than mojohaus url change

There we go 👏🏻

@olamy olamy merged commit 3e9fe41 into jenkinsci:master Dec 29, 2021
@NotMyFault NotMyFault deleted the chore/master/do-https-lookups branch December 29, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants