Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modern Jenkins versions to override PNG with SVG icons #229

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Nov 17, 2021

Replace icon paths to allow modern Jenkins versions to override these and put in SVGs over PNGs where applicable, in preparation of jenkinsci/jenkins#5778

Before After
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@NotMyFault
Copy link
Member Author

@olamy 👀

@olamy olamy merged commit fd3f067 into jenkinsci:master Dec 1, 2021
@NotMyFault NotMyFault deleted the style/master/allow-icon-override branch December 1, 2021 09:13
@NotMyFault
Copy link
Member Author

@olamy Can we may get a release? The core PR is blocked until the plugin PRs are pulled and included in some release.
Thanks in advance.

@timja
Copy link
Member

timja commented Dec 22, 2021

@olamy can we get a release please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants