Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates InjectedTest in a named package. #587

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Mar 12, 2024

This makes the test friendlier to JUnit results collection when working with PCT or in multi-module projects in general.

The package name is derived from groupId and artifactId, but can also be provided through configuration if needed.

Testing done

Existing IT parent-4x exercises this, though doesn't make any assertion about the actual package name being used. Could add a new one if needed.

Submitter checklist

This makes the test friendlier to JUnit results collection when working with PCT or in multi-module projects in general.

The package named is derived from groupId and artifactId, but can also be provided through configuration if needed.
@Vlatombe Vlatombe requested review from jglick and basil March 12, 2024 14:17
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, seems reasonable to use a unique name for each plugin to facilitate test result visualizations.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks helpful. Should not break any tools which run -Dtest=InjectedTest since that will match a test inside a package.

jglick

This comment was marked as resolved.

@MarkEWaite MarkEWaite merged commit 9ae61e8 into jenkinsci:master Mar 13, 2024
5 checks passed
@Vlatombe Vlatombe deleted the package-injectedTest branch March 13, 2024 07:44
@basil basil mentioned this pull request Apr 12, 2024
basil added a commit to jenkinsci/plugin-compat-tester that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants