Begin mini-migration from Plugin-GitHash to Implementation-Build
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
only minor NIT is that Implementation-Build implies it is build related rather than source related (e.g. a tag can be built multiple times - locally. or on CI if the deploy failed due to an artifactory issue etc), esp as we have Jenkins which also has builds.
|
I agree that the name isn't ideal, but it is what is recommended in https://www.mojohaus.org/buildnumber-maven-plugin/usage.html so more people are likely to be using that name than any other name. |
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with jenkinsci/pom#419, put the Git hash in
Implementation-Buildrather thanPlugin-GitHash. For now I am keeping it inPlugin-GitHashsince it was (very recently) added there for PCT, but I will update PCT to start consumingImplementation-Buildinstead and plan to rip outPlugin-GitHashshortly (in a month or so) once it's no longer used by anything (not much is using it today, just the AWS Java SDK plugin I think).