Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for additional plugin manifest entries #467

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Apr 13, 2023

I erroneously forgot to push the latest changes to #436 at the time which mean the IT for it was still sitting on my local machine only.

Whilst an ITs was adapted there was still no IT to cover a multi-module reactor build - so this IT ensures we have coverage for that.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

I erroneously forgot to push the latest changes to 436 which mean the IT
for it was still sitting on my local machine only.

Whilst some ITs where adapted there was still no IT to cover a
multi-module reactor build - so this IT ensures we have coverage for
that.
@jtnord jtnord requested a review from basil April 13, 2023 16:35
src/it/metadata-it/verify.groovy Outdated Show resolved Hide resolved
src/it/metadata-it/verify.groovy Outdated Show resolved Hide resolved
@basil basil added test and removed internal labels Apr 14, 2023
@basil basil changed the title Add IT missing from manfest entries Add integration test for additional plugin manifest entries Apr 14, 2023
@basil basil merged commit a345aea into jenkinsci:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants