Remove overrideWarAdditions option
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added a commit
to basil/plugin-compat-tester
that referenced
this pull request
Mar 28, 2023
This was referenced Mar 28, 2023
jtnord
approved these changes
Mar 28, 2023
|
Ready to go with this @jtnord? I saw that the internal test of jenkinsci/plugin-compat-tester#505 passed. |
Yup, this is ready to go. |
jtnord
approved these changes
Mar 28, 2023
basil
added a commit
to jenkinsci/plugin-compat-tester
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkinsci/bomis using-DoverrideWarAdditions, while CloudBees is not. This PR removes the most controversial part of-DoverrideWarAdditions(adding the entries to test scope) while retaining the part of it that is needed forjenkinsci/bom(adding the bundled plugins that are not part of the original dependency tree to the dependency management section), now the default behavior. Hopefully this will not cause any problems for CloudBees so that we can unify the two implementations.I plan to test this in
jenkinsci/bomand would request someone also test this on the CloudBees side.