Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-53500] Windows support for container step #626

Merged
merged 48 commits into from
Oct 30, 2019
Merged

[JENKINS-53500] Windows support for container step #626

merged 48 commits into from
Oct 30, 2019

Commits on Oct 22, 2019

  1. test-in-k8s better suited to iterative use.

    @jglick
    jglick committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    81bd573 View commit details
    Browse the repository at this point in the history

  2. Added LinuxFilter.

    @jglick
    jglick committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    af5faad View commit details
    Browse the repository at this point in the history

  3. [JENKINS-57256] Sketch of test of Windows pods.

    @jglick
    jglick committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    a6cab42 View commit details
    Browse the repository at this point in the history

  4. Comment.

    @jglick
    jglick committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    2a0a670 View commit details
    Browse the repository at this point in the history

  5. Adding some logging to LinuxFilter.

    @jglick
    jglick committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    b27b537 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Pending jenkinsci#623, using PodTemplateFilter to set nodeSelector do… 

    …es not work.

Also needed to skip pods using nodeAffinity.
    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    6619b89 View commit details
    Browse the repository at this point in the history

  2. Stray newline.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    14f3792 View commit details
    Browse the repository at this point in the history

  3. Working around aws/containers-roadmap#542.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    3e09dea View commit details
    Browse the repository at this point in the history

  4. Oops, cannot delete jenkins pod or test collection in CI breaks.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    f3d304e View commit details
    Browse the repository at this point in the history

  5. Must use JENKINS_URL not JENKINS_DIRECT_CONNECTION.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    47a77a2 View commit details
    Browse the repository at this point in the history

  6. Switching to official image.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    12b7069 View commit details
    Browse the repository at this point in the history

  7. Following up 47a77a2 with a warning in documentation.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    15568d7 View commit details
    Browse the repository at this point in the history

  8. Appending .svc.cluster.local to work around aws/containers-roadmap#236.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    24c97c2 View commit details
    Browse the repository at this point in the history

  9. Reproduced JENKINS-53500 error.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    230a289 View commit details
    Browse the repository at this point in the history

  10. Let us test both bat and powershell steps.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    217af86 View commit details
    Browse the repository at this point in the history

  11. Just shell: cmd seems to suffice for basic functionality.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    2c4916e View commit details
    Browse the repository at this point in the history

  12. Autodetect OS so ContainerStep.shell does not normally need to be spe… 

    …cified.
    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    06479de View commit details
    Browse the repository at this point in the history

  13. Cheaper and easier to use Launcher.isUnix.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    54771c4 View commit details
    Browse the repository at this point in the history

  14. Reverting some unnecessary changes.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    179b9aa View commit details
    Browse the repository at this point in the history

  15. Demonstrating that cd commands work.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    f32db53 View commit details
    Browse the repository at this point in the history

  16. Fixing environment variable bindings.

    @jglick
    jglick committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    b774e48 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Making sure existing tests can run in a mixed-OS cluster.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    9238e2d View commit details
    Browse the repository at this point in the history

  2. Proving that Windows builds can survive master restarts.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    72ee637 View commit details
    Browse the repository at this point in the history

  3. More efficient way of skipping Windows-specific tests.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    f34e71c View commit details
    Browse the repository at this point in the history

  4. Documenting assumeWindows.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    895b317 View commit details
    Browse the repository at this point in the history

  5. More precise to say that we should use cmd-oriented syntax iff the se… 

    …lected shell is indeed cmd.
    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    2d30ad7 View commit details
    Browse the repository at this point in the history

  6. So far as I can tell, \n works fine to delineate commands even to cmd… 

    ….exe.
    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    0fd290d View commit details
    Browse the repository at this point in the history

  7. podTemplate and container are frequently used steps, not “advanced” a… 

    …nd certainly not “deprecated”.
    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    ebcfb88 View commit details
    Browse the repository at this point in the history

  8. containerLog, on the other hand, is not normally useful.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    c81198a View commit details
    Browse the repository at this point in the history

  9. Config form for ContainerStep did not match its actual configurable f… 

    …ields.
    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    a61ba8c View commit details
    Browse the repository at this point in the history

  10. Documenting ContainerStep.shell and why it does not do what you proba… 

    …bly thought and why you should probably ignore it.
    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    d8992c5 View commit details
    Browse the repository at this point in the history

  11. ContainerStep.shell blank means unset.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    0e2e0be View commit details
    Browse the repository at this point in the history

  12. Merge branch 'snippetizer' into windows-JENKINS-53500

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    293f1c3 View commit details
    Browse the repository at this point in the history

  13. More advice on user shell selection.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    45bfb1c View commit details
    Browse the repository at this point in the history

  14. Merge branch 'snippetizer' into windows-JENKINS-53500

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    dadd5f2 View commit details
    Browse the repository at this point in the history

  15. Documenting that ContainerStep.shell gets defaulted automatically on … 

    …Windows.
    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    fd851c8 View commit details
    Browse the repository at this point in the history

  16. Established baseline Linux behavior for Launcher.kill in ContainerExe… 

    …cDecorator.
    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    184667b View commit details
    Browse the repository at this point in the history

  17. Launcher.kill in ContainerExecDecorator does not yet work in Windows.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    5e9c181 View commit details
    Browse the repository at this point in the history

  18. Fixing SecretsMasker on Windows.

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    06ea50a View commit details
    Browse the repository at this point in the history

  19. Status information from SecretsMasker exec should go to a logger, not… 

    … System.err.
    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    3220391 View commit details
    Browse the repository at this point in the history

  20. SpotBugs

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    24215e2 View commit details
    Browse the repository at this point in the history

  21. Fixed assertion. (How did this pass before?)

    @jglick
    jglick committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    aa7002d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. SpotBugs

    @jglick
    jglick committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    8bcf318 View commit details
    Browse the repository at this point in the history

  2. Adding example of Windows build.

    @jglick
    jglick committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    d3eaab0 View commit details
    Browse the repository at this point in the history

  3. Noting Windows support, and deleting apparently bogus example of inhe… 

    …ritFrom pending a working variant.
    @jglick
    jglick committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    80ce964 View commit details
    Browse the repository at this point in the history

  4. Deleting misleading suggestion to use ContainerStep.shell.

    @jglick
    jglick committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    b94478d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'snippetizer' into windows-JENKINS-53500

    @jglick
    jglick committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    ac0123e View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Helpful for test-in-k8s.sh to note any skip messages.

    @jglick
    jglick committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    bcd7391 View commit details
    Browse the repository at this point in the history