Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picking a safer name for clusters #619

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Picking a safer name for clusters #619

merged 1 commit into from
Oct 10, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 10, 2019

#618 failed with

docker: Error response from daemon: Invalid container name (jenkins-Plugins-kubernetes-plugin-dependabot%2Fmaven%2Forg.jenkins-ci.plugins-docker-workflow-1.21-1-control-plane), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed.

@jglick
Copy link
Member Author

jglick commented Oct 10, 2019

Still waiting for CI to confirm that the cleanup function picks up the variable.

@jglick
Copy link
Member Author

jglick commented Oct 10, 2019

Yes, it works.

@jglick jglick merged commit 42a0727 into jenkinsci:master Oct 10, 2019
@jglick jglick deleted the kind-cluster branch October 10, 2019 13:59
@Vlatombe Vlatombe added the chore Maintenance label Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @Vlatombe