Verifying that tools do not assume sh is in /bin/sh #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jun 4, 2019
| @@ -0,0 +1,7 @@ | |||
| podTemplate(label: 'bourneShellElsewhereInPath', containers: [containerTemplate(name: 'kaniko', image: 'gcr.io/kaniko-project/executor:debug', command: 'sleep', args: '99d')]) { | |||
| node('bourneShellElsewhereInPath') { | |||
| container(name: 'kaniko') { | |||
There was a problem hiding this comment.
Without the ContainerExecDecorator patch, this fails unless you
-container(name: 'kaniko') {
+container(name: 'kaniko', shell: '/busybox/sh') {| podTemplate(label: 'bourneShellElsewhereInPath', containers: [containerTemplate(name: 'kaniko', image: 'gcr.io/kaniko-project/executor:debug', command: 'sleep', args: '99d')]) { | ||
| node('bourneShellElsewhereInPath') { | ||
| container(name: 'kaniko') { | ||
| sh 'ls -la /' |
There was a problem hiding this comment.
Without the BourneShellScript patch, this fails unless you
-sh 'ls -la /'
+sh '''#!/busybox/sh -ex
+ ls -la /
+'''+ ls -la / ls: can't open '/': Value too large for defined data type total 0
Probably due to: https://issues.jenkins-ci.org/browse/JENKINS-46076?focusedCommentId=368388&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-368388 java.lang.AssertionError: Expected: a string containing "Labels must follow required specs - https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set: mypod!123" but: was "Started Running in Durability level: MAX_SURVIVABILITY [Pipeline] podTemplate [Pipeline] // podTemplate [Pipeline] End of Pipeline " at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at org.jvnet.hudson.test.JenkinsRule.assertLogContains(JenkinsRule.java:1308) at org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStepExecutionTest.testBadLabel(PodTemplateStepExecutionTest.java:85)
5 tasks
|
I'll hold this until there is a release of |
This reverts commit 575a8f8. Not clear that this would actually fix the flake. RCA in JENKINS-46076.
This was referenced Jun 7, 2019
dwnusbaum
reviewed
Jul 5, 2019
Co-Authored-By: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
Vlatombe
added a commit
that referenced
this pull request
Sep 12, 2019
Not needed anymore since #490
Vlatombe
added a commit
to Vlatombe/kubernetes-plugin
that referenced
this pull request
Sep 12, 2019
Not needed anymore since jenkinsci#490
This was referenced Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/durable-task-plugin#95. @Vlatombe