[JENKINS-73138] Replace JenkinsRuleNonLocalhost and test-in-k8s with ktunnel
#1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jul 26, 2024
Jenkinsfile-release
Outdated
There was a problem hiding this comment.
Seems to predate JEP-229.
jglick
commented
Jul 26, 2024
| @@ -2,6 +2,8 @@ | |||
| set -euxo pipefail | |||
| cd $(dirname $0) | |||
|
|
|||
| : ${WORKSPACE_TMP:=/tmp} | |||
There was a problem hiding this comment.
Makes it simpler to try this script locally.
… into JenkinsRuleNonLocalhost-JENKINS-73138
6 tasks
amuniz
approved these changes
Jul 30, 2024
|
Tested locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1567 and a lot of historical tricks like #1495 with a simpler reverse proxy system as outlined in https://issues.jenkins.io/browse/JENKINS-73138.
We possibly could retain
test-in-k8s.shas an alternative, since in that mode the HTTP (and TCP) ports are being proxied by a K8sService, and I think in a single-node cluster like Kind if you picktype: NodePortthe connection will be treated as coming from the local node so listening on 127.0.0.1 would work. But K8s networking may be more complicated than that so I am not sure. Anyway it seems best to have a single mode of operations in CI and for local development to minimize confusion, and running Maven inside the pod in CI builds is nonstandard.