Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerations for jenkis pod #807

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

tombokombo
Copy link

Changes

Add possibility to set tolerations for jenkins pod.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Release Notes

- Add tolerations for jenkins pod in helm chart

Signed-off-by: tombokombo <tombo@sysart.tech>
@brokenpip3
Copy link
Collaborator

Hi @tombokombo to support the toleration in the result jenkins pod what you did is not enough you need to modify the go struct and the crds, you can check this PR as example :)

@tombokombo
Copy link
Author

tombokombo commented Mar 17, 2023

Hi @brokenpip3 you are perfectly right, but it's already there, in code
https://github.com/jenkinsci/kubernetes-operator/blob/master/pkg/configuration/base/resources/pod.go#L383
and CRD:
https://github.com/jenkinsci/kubernetes-operator/blob/master/chart/jenkins-operator/crds/jenkins-crd.yaml#L1329.
It was just missing in chart. We are running this patched version in production.
BTW behavior is same as nodeSelector, hostAliases, which means pod is not recreated after change of nodeSelector, tolerations, hostAliases and maybe other fields. I will take a look on this, but in another PR.

@brokenpip3
Copy link
Collaborator

Oh great! I was no aware that we already support that, perfect.
Thanks for your contribution!

@brokenpip3 brokenpip3 merged commit e36441a into jenkinsci:master Mar 17, 2023
brokenpip3 added a commit to brokenpip3/kubernetes-operator that referenced this pull request Mar 21, 2023
brokenpip3 added a commit that referenced this pull request Mar 22, 2023
- prepare to switch from `master` to `main`
- avoid to run workflow in case is not needed
- add a way to bump the lts via make
- use latest jenkins lts 2.387.1
- add the docker labels
- update base plugins
- fix #797 
- Add more tests with bats
- Update base plugin to latest version
- Temporary revert #807 
- Better nightly job
@brokenpip3
Copy link
Collaborator

sorry @tombokombo I had to revert this because I need the master branch to be ci-happy so we can push nightly versions. I don't know why but this change broke one e2e test, I opened this to track and fix the issue: #808.
Will try to put the toleration back asap, sorry for the inconvenient.

brokenpip3 pushed a commit that referenced this pull request May 26, 2023
Signed-off-by: tombokombo <tombo@sysart.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants