Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin size is too high and contains unused dependencies #30

Open
nfalco79 opened this issue Jun 16, 2023 · 1 comment
Open

Plugin size is too high and contains unused dependencies #30

nfalco79 opened this issue Jun 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nfalco79
Copy link
Member

What feature do you want to see added?

When I implemented the PR #29 as artifact of the build I get an HPI of 31Mb.
When I see inside HPI I'm surprised that there was a lot of dependencies that sound strange inside a plugin.
Just and example the whole spring framework (included with commit 99df204), jetty embedded server and so on.
Also it the could works thanks to the jenkins plugin classloading it's a problem if all plugin do that. Because of memory, problem at runtime when comunicate with other plugins same class loaded from different classloader, time of startup and so on.

Upstream changes

No response

@nfalco79 nfalco79 added the enhancement New feature or request label Jun 16, 2023
nfalco79 added a commit to nfalco79/keeper-secrets-manager-plugin that referenced this issue Jun 16, 2023
nfalco79 added a commit to nfalco79/keeper-secrets-manager-plugin that referenced this issue Jun 16, 2023
…use just one JSON parser preferring that one that comes from Jenkins core.
nfalco79 added a commit to nfalco79/keeper-secrets-manager-plugin that referenced this issue Jun 16, 2023
…use just one JSON parser preferring that one that comes from Jenkins core.
nfalco79 added a commit to nfalco79/keeper-secrets-manager-plugin that referenced this issue Jun 22, 2023
…use just one JSON parser preferring that one that comes from Jenkins core.
nfalco79 added a commit to nfalco79/keeper-secrets-manager-plugin that referenced this issue Jun 22, 2023
…use just one JSON parser preferring that one that comes from Jenkins core.
nfalco79 added a commit to nfalco79/keeper-secrets-manager-plugin that referenced this issue Jun 22, 2023
…use just one JSON parser preferring that one that comes from Jenkins core.
nfalco79 added a commit to nfalco79/keeper-secrets-manager-plugin that referenced this issue Jun 22, 2023
…use just one JSON parser preferring that one that comes from Jenkins core.
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Dec 18, 2023

This is now a blocking bug. Jenkins 2.434 and later will refuse to load a plugin that includes the Jenkins test harness. Jenkins 2.434 includes the pull request:

The Jenkins test harness causes unexpected failures when it is included in a Jenkins plugin. Refer to the following issue reports for examples:

This plugin will be unusable with Jenkins releases after 2.434 until a new release is created that includes the changes in:

Other changes may be required, but the changes in that pull request are certainly required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants