Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental flag to run Jenkins without YUI #9489

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jul 20, 2024

The YUI library is old and no longer maintained.

Add a user experimental flag to disable YUI. The flag is disabled by default. When enabling the flag, all the YUI related js libraries and css classes are not loaded.

Following PR are required to get Jenkins to not show any errors
#9488
#9453
#7569

Some plugins that use YUI (not complete):
credentials
ldap
global-build-stats
build-monitor
categorized-view
matrix-project

Plugins that make use of makeButton (not complete)
credentials (fixed with jenkinsci/credentials-plugin#533)
openid

acceptance-test-harness

Testing done

Proposed changelog entries

Add a user experimental flag to run Jenkins without the YUI JavaScript library. Plugin authors should enable this flag and fix any issues that result from the removal of the YUI library.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

The YUI library is old and no longer maintained.

Add a user experimental flag to disable YUI. It's disabled by default.
When enabling all the YUI related js libraries and css classes are not
loaded.

Following PR are required to get Jenkins to not show any errors

eventually jenkinsci#7569

Some plugins that use YUI (not complete):
credentials
ldap
global-build-stats
build-monitor
categorized-view

Plugins that make use of makeButton (not complete)
credentials (fixed with jenkinsci/credentials-plugin#533)
openid

acceptance-test-harness
@janfaracik
Copy link
Contributor

Looks good to me! Thanks for compiling that list.

Co-authored-by: Jan Faracik <43062514+janfaracik@users.noreply.github.com>
@MarkEWaite MarkEWaite added the developer Changes which impact plugin developers label Jul 21, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 21, 2024
@NotMyFault NotMyFault merged commit 0255a59 into jenkinsci:master Jul 22, 2024
16 checks passed
@daniel-beck
Copy link
Member

Some plugins that use YUI (not complete):

Add matrix-auth and azure-ad to the list due to their use of YAHOO.lang.

@mawinter69
Copy link
Contributor Author

I've collected all usages of YUI here:
https://docs.google.com/spreadsheets/d/1UjvtFmNmEdjMN5DUoFxJfBryA8q-E5_HwOzVKbVG9b0/edit?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants