Refine table and tabs

[janfaracik]

Really small/subtle pull request to refine the table and tabs components. These changes are more obvious in dark mode.

Differences

• Tightens up the padding, bringing it more inline with the recently introduced cards
• Slightly more rounded, again bringing it more inline with cards
• Borders are now visible when in dark mode (same as cards)

Before

After

Before

After

Testing done

• Tables and tabs look as expected

Proposed changelog entries

• Refine tables and tabs with reduced padding, rounded corners to match cards, and borders that are visible in dark mode.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

Could you add screenshots with multiple views (as I think that doesn't look the best atm)?

[janfaracik]

Could you add screenshots with multiple views (as I think that doesn't look the best atm)?

Agree there - this MR hasn't changed how the tabs are displayed, more the background of them.

Before

After

Before

After

[janfaracik]

/label web-ui

[timja]

LGTM

[uhafner]

Looks good (in the screenshots, I did not test it).

Did you check if this has no negative impact on plugins that use Boostrap tabs or Jenkins tables in table column tooltips? The warnings and coverage plugins are 2 examples.

[mawinter69]

The screenshots look as if they were taken on top of #9410 because the sort arrows look different to what we have now

[janfaracik]

The screenshots look as if they were taken on top of #9410 because the sort arrows look different to what we have now

Good spot - I must have been half asleep doing this. I've updated the screenshots, only difference is the arrows are correct now. Thanks!

[janfaracik]

Looks good (in the screenshots, I did not test it).

Did you check if this has no negative impact on plugins that use Boostrap tabs or Jenkins tables in table column tooltips? The warnings and coverage plugins are 2 examples.

Yup - working fine:

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

What's the unit change here for? Weirdos People who "zoom text only" on web pages?

[timja]

This explains it well: https://stackoverflow.com/a/43131958

Generally in new web development rem is used pretty much exclusively (mostly) as it adapts to the users font-size

[daniel-beck]

Could you be more specific here? The linked post does not seem to answer why the non-font related sizes here were changed to be dependent on font. The only difference I was able to identify is font-only zoom, which apparently nobody uses anymore anyway.