Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine radio inputs #9380

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Refine radio inputs #9380

merged 2 commits into from
Jun 15, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 12, 2024

Small MR to refine the radio inputs in Jenkins. Padding has been adjusted/corrected (see screenshots below), animations have been refined, animations fixed in Safari and SCSS simplified.

Before
image

After
image

Testing done

  • Tried radios in Jenkins, looks fine. Tried radios in Design Library, looks fine.

Proposed changelog entries

  • Refine radio inputs.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 14, 2024
@MarkEWaite MarkEWaite added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jun 14, 2024
@MarkEWaite MarkEWaite merged commit 0e54478 into jenkinsci:master Jun 15, 2024
16 checks passed
@janfaracik janfaracik deleted the refactor-radios branch June 15, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants