Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust heading weights and sizes #9366

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 9, 2024

Small and subtle merge request to decrease the weight of headings slightly and to adjust their sizes so they align with whole pixels.

Previously for example, h2 was 1.35rem which is 1.35 * 16 = 21.6, now it's been adjusted to 1.375 * 16 = 22. This should result in slightly crisper text.

Before
image

After
image

Testing done

  • Headings appear as expected

Proposed changelog entries

  • Adjust heading weights and sizes.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Jun 9, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja requested a review from a team June 9, 2024 09:42
@timja
Copy link
Member

timja commented Jun 10, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 10, 2024
@MarkEWaite MarkEWaite merged commit a6542b9 into jenkinsci:master Jun 11, 2024
17 checks passed
@janfaracik janfaracik deleted the update-heading-appearance branch June 11, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants