Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate words in Javadoc and test comments #9178

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

growfrow
Copy link
Contributor

@growfrow growfrow commented Apr 18, 2024

Remove duplicated words in Javadoc and test comments

Testing done

No automated tests because the changes only affect Javadoc comments. Confirmed that no new warnings or errors are reported by Javadoc generation.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented Apr 18, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes in documentation. Thanks.

@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Apr 18, 2024
@MarkEWaite MarkEWaite changed the title chore: remove repetitive words Remove duplicate words in Javadoc comments Apr 18, 2024
@MarkEWaite MarkEWaite changed the title Remove duplicate words in Javadoc comments Remove duplicate words in Javadoc and JavaScript comments Apr 18, 2024
@MarkEWaite MarkEWaite self-assigned this Apr 18, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicated words should not be removed from our copy of the YahooUI JavaScript library because it will make later comparisons with upstream more difficult.

I've completed the "Testing done" section of the pull request template. It is not optional. I also checked that no new errors or warnings were generated by the Javadoc changes.

core/src/main/java/hudson/model/Label.java Outdated Show resolved Hide resolved
@MarkEWaite
Copy link
Contributor

Thanks for the pull request @growfrow. Could you complete the requested changes so that it can be reviewed again?

@MarkEWaite
Copy link
Contributor

When submitting future pull requests, please be sure to complete the pull request template. It assures that you've done the things that are needed for pull request review and it helps the maintainers understand what is intended by the change.

Signed-off-by: growfrow <growfrow@outlook.com>
@growfrow
Copy link
Contributor Author

When submitting future pull requests, please be sure to complete the pull request template. It assures that you've done the things that are needed for pull request review and it helps the maintainers understand what is intended by the change.

Thank you for your suggestion.

@MarkEWaite MarkEWaite changed the title Remove duplicate words in Javadoc and JavaScript comments Remove duplicate words in Javadoc and test comments Apr 18, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes look good to me.

@NotMyFault NotMyFault merged commit 136d310 into jenkinsci:master Apr 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants