-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate words in Javadoc and test comments #9178
Conversation
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes in documentation. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicated words should not be removed from our copy of the YahooUI JavaScript library because it will make later comparisons with upstream more difficult.
I've completed the "Testing done" section of the pull request template. It is not optional. I also checked that no new errors or warnings were generated by the Javadoc changes.
Thanks for the pull request @growfrow. Could you complete the requested changes so that it can be reviewed again? |
When submitting future pull requests, please be sure to complete the pull request template. It assures that you've done the things that are needed for pull request review and it helps the maintainers understand what is intended by the change. |
Signed-off-by: growfrow <growfrow@outlook.com>
Thank you for your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Changes look good to me.
Remove duplicated words in Javadoc and test comments
Testing done
No automated tests because the changes only affect Javadoc comments. Confirmed that no new warnings or errors are reported by Javadoc generation.
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist