Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pipeline-stage-view with graph-view in the setup wizard #8884

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Jan 21, 2024

The change proposed replaces the pipeline-stage-view plugin with the pipeline-graph-view plugin in the setup wizard.
Given the pipeline-stage-view is closely tied to BO - which was removed from the setup wizard some time ago - I'd like to suggest replacing it with the graph-view plugin, providing a more modern overview of your pipelines.

It's worth mentioning that the graph-view plugin is under active development and not feature-stalled like the stage view one (thanks to @timja 💯 )

Testing done

The plugin is installed as intended, when setting up a new instance.

Proposed changelog entries

  • JENKINS-XXXXX, human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Signed-off-by: Alexander Brandes <mc.cache@web.de>
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Jan 21, 2024
@NotMyFault NotMyFault requested a review from a team January 21, 2024 13:40
@daniel-beck
Copy link
Member

daniel-beck commented Jan 21, 2024

pipeline-stage-view is closely tied to BO

How so? AFAICT they're completely unrelated implementations, all they have in common is use stages (pipeline-stage-step) to organize content. From that perspective, Graph View is just as tied to BO.

@NotMyFault
Copy link
Member Author

pipeline-stage-view is closely tied to BO

How so? AFAICT they're completely unrelated implementations, all they have in common is use stages (pipeline-stage-step) to organize content. From that perspective, Graph View is just as tied to BO.

Oh, I was believing that stage-view was the BO attempt to view pipelines, not that it's a dependency of BO.
But I would like to replace it still, given the stage view provides a more modern UI integrating with modern Jenkins, layout and UX wise. The feature-stallness of stage-view is another point I'd like to see it replaced.

@mawinter69
Copy link
Contributor

In your initial description you have 2 places where you wrote stage-view but meant graph-view I think.

I'd like to suggest replacing it with the graph-view plugin, providing a more modern overview over your pipelines.
It's worth mentioning that the graph-view plugin is under active development and not feature-stalled like the stage view one

@NotMyFault
Copy link
Member Author

In your initial description you have 2 places where you wrote stage-view but meant graph-view I think.

I'd like to suggest replacing it with the graph-view plugin, providing a more modern overview over your pipelines.
It's worth mentioning that the graph-view plugin is under active development and not feature-stalled like the stage view one

Oh absolutely 🤦
Thanks for finding, I'll fix it right away.

@NotMyFault NotMyFault merged commit 02c99cb into jenkinsci:master Mar 3, 2024
16 checks passed
@NotMyFault NotMyFault deleted the stage-to-graph branch March 3, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants