Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssh Command modified in PrivateKeyProvider.java File in CLI module #8756

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Ssh Command modified in PrivateKeyProvider.java File in CLI module #8756

merged 1 commit into from
Dec 6, 2023

Conversation

SomasekharSunkari
Copy link
Contributor

The SSH Command availble in PrivateKeyProviderTest.java not working as expected . It was generating TO MANY ARGUMENTS exception . By making the -p to -P working fine.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added documentation Improvements or additions to documentation skip-changelog Should not be shown in the changelog and removed documentation Improvements or additions to documentation labels Dec 6, 2023
@MarkEWaite
Copy link
Contributor

@SomasekharSunkari please use the pull request template in future pull requests. It includes components that we use to generate the weekly changelog and the LTS changelog. It includes checklists to help first time contributors like you.

I don't think that the pull request template needs to be included in this pull request, since this pull request is only changing the text in some Java comments. We won't include this in the changelog because it has no user visible change.

@MarkEWaite MarkEWaite merged commit dca009b into jenkinsci:master Dec 6, 2023
16 checks passed
Copy link

welcome bot commented Dec 6, 2023

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


@MarkEWaite
Copy link
Contributor

I merged without waiting the usual 24 hour period because this is purely changes to text in the comment.

@basil basil changed the title Ssh Command modified in PrivateKeyProvider.java File in cil module Ssh Command modified in PrivateKeyProvider.java File in CLI module Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants