Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70779] Address Stylelint 15.x Deprecations #7769

Merged

Conversation

SaarthakMaini
Copy link
Contributor

@SaarthakMaini SaarthakMaini commented Mar 26, 2023

These rules will still work in the current release of stylelint, but they would be removed in the next major release.

Reference PR : #7756

See JENKINS-70779.

Reference Document

Testing done

We can confirm that the changes have been made from the picture attached below.

On running yarn run lint , the deprecation warning isn't appearing anymore

Before

image

After

image

Proposed changelog entries

  • Entry 1: 70779, Address Stylelint 15.x Deprecations

Desired Review

@NotMyFault

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples)

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

These rules will still work in the current release of stylelint, but they would be removed in the next major release.
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Mar 27, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 27, 2023
@NotMyFault NotMyFault merged commit 9a9bb7d into jenkinsci:master Mar 28, 2023
@SaarthakMaini SaarthakMaini deleted the address-stylelint-rule-deprecation branch March 28, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants