Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70809] - Fix "delete build" button overflow the side-panel #7735

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

mamh2021
Copy link
Contributor

@mamh2021 mamh2021 commented Mar 16, 2023

See JENKINS-70809

Proposed changelog entries

  • Fix "delete build" button text overflow.

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Signed-off-by: bright.ma <maminghui6@xiaomi.com>
@NotMyFault NotMyFault added the bug For changelog: Minor bug. Will be listed after features label Mar 16, 2023
@NotMyFault NotMyFault changed the title [JENKINS-70809]fixup "delete build" button overflow the side-panel [JENKINS-70809] - Fix "delete build" button overflow the side-panel Mar 16, 2023
@NotMyFault NotMyFault added the web-ui The PR includes WebUI changes which may need special expertise label Mar 16, 2023
@NotMyFault NotMyFault requested a review from a team March 16, 2023 12:02
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Thanks for proposing a fix for the issue risen. What do you think about my changes submitted? Instead of simply restoring the original behavior, we could display the full name of the build to delete, instead of abbreviating it after a few characters.

war/src/main/less/modules/side-panel-tasks.less Outdated Show resolved Hide resolved
Signed-off-by: bright.ma <maminghui6@xiaomi.com>
@mamh2021
Copy link
Contributor Author

Another question, I'm not sure.
in file war/src/main/less/modules/side-panel-tasks.less, there are two same ".task-link-text " at line 109 and 113.
should one be deleted?

   109	  .task-link-text {
   110	    display: contents;
   111	  }
   112	
   113	  .task-link-text {
   114	    display: contents;
   115	    word-break: break-word;
   116	  }

@NotMyFault NotMyFault requested a review from a team March 17, 2023 11:54
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two same ".task-link-text

Previously, we had

  .task-link-text {
    display: contents;
  }

  .task-link-text {
    display: contents;
  }

which is declared twice. I removed the top one via browsertools and didn't notice anything odd, so I'd say we can safely remove it, unless there's some context I am missing. @janfaracik any idea?

@NotMyFault NotMyFault requested review from a team and removed request for a team March 18, 2023 17:58
@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 23, 2023
@NotMyFault NotMyFault merged commit 2e2b00a into jenkinsci:master Mar 25, 2023
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Apr 18, 2023
…enkinsci#7735)

* [JENKINS-70809]fixup "delete build" button overflow the side-panel

Signed-off-by: bright.ma <maminghui6@xiaomi.com>

* [JENKINS-70809] add word-break to task-link-text

Signed-off-by: bright.ma <maminghui6@xiaomi.com>

---------

Signed-off-by: bright.ma <maminghui6@xiaomi.com>
Co-authored-by: bright.ma <maminghui6@xiaomi.com>
(cherry picked from commit 2e2b00a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants