-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-70809] - Fix "delete build" button overflow the side-panel #7735
Conversation
Signed-off-by: bright.ma <maminghui6@xiaomi.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Thanks for proposing a fix for the issue risen. What do you think about my changes submitted? Instead of simply restoring the original behavior, we could display the full name of the build to delete, instead of abbreviating it after a few characters.
Signed-off-by: bright.ma <maminghui6@xiaomi.com>
Another question, I'm not sure.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are two same ".task-link-text
Previously, we had
.task-link-text {
display: contents;
}
.task-link-text {
display: contents;
}
which is declared twice. I removed the top one via browsertools and didn't notice anything odd, so I'd say we can safely remove it, unless there's some context I am missing. @janfaracik any idea?
/label ready-for-merge This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback. |
…enkinsci#7735) * [JENKINS-70809]fixup "delete build" button overflow the side-panel Signed-off-by: bright.ma <maminghui6@xiaomi.com> * [JENKINS-70809] add word-break to task-link-text Signed-off-by: bright.ma <maminghui6@xiaomi.com> --------- Signed-off-by: bright.ma <maminghui6@xiaomi.com> Co-authored-by: bright.ma <maminghui6@xiaomi.com> (cherry picked from commit 2e2b00a)
See JENKINS-70809
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).