Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-49138] Build Now to redirect to new build #7633

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 7, 2023

See JENKINS-49138. There are a lot of different UI gestures to trigger a build, and this just covers one of them so far, and perhaps not in the ideal way (needs UX design in some cases). Not sure if I have the appetite to continue, or if it makes sense to open for review even when incomplete.

Testing done

build-now.mp4

Proposed changelog entries

  • TBD

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

setTimeout(function () {
new Ajax.Request(t.getHeader('Location') + 'api/json?tree=executable[url]', {
onSuccess: function (t2) {
if (t2.status === 200 && t2.responseJSON.executable != null && t2.responseJSON.executable.url != null) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -30,7 +30,22 @@ THE SOFTWARE.
<l:task href="${url}/build?delay=0sec" icon="icon-clock icon-md" onclick="${it.parameterized?null:'return build_' + id + '(this)'}" permission="${it.BUILD}" post="${!it.parameterized}" title="${it.buildNowText}"/>
<script>
function build_${id}(a) {
new Ajax.Request(a.href);
new Ajax.Request(a.href, {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Please take a moment and address the merge conflicts of your pull request. Thanks!

@jglick
Copy link
Member Author

jglick commented May 1, 2023

Ideally would wait for #7635.

@jglick
Copy link
Member Author

jglick commented Dec 13, 2023

This is now actionable again, back to my to-do list…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unresolved-merge-conflict There is a merge conflict with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant