Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60866] Extract inline JS from progressive rendering #6860

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Jul 16, 2022

See JENKINS-60866.

Right now I am feeling pretty good about our ability to make st:bind CSP-compliant in a compatible way (that ended up in #6865). This PR just extracts inline JS from progressiveRendering that is defined there directly.

This tag is used e.g. for /asynchPeople/.

I checked whether any callbacks exist that aren't just function names via GH search and did not find any (but that's not a thorough search).

The chosen approach should be compatible with pages having multiple progressiveRendering, but not with AJAX supplied progressiveRendering (which I doubt exist, but cannot be sure). Please let me know if this should be done with Behavior instead.

Proposed changelog entries

Too minor (unless we count the redefinition of the argument)

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck daniel-beck requested a review from Wadeck July 16, 2022 12:34
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Jul 16, 2022
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisionally approving if Tim's suggestions are addressed.

@daniel-beck daniel-beck self-assigned this Jul 18, 2022
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@daniel-beck daniel-beck removed their assignment Jul 18, 2022
@daniel-beck
Copy link
Member Author

Thanks everyone!

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

@daniel-beck daniel-beck added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 18, 2022
@daniel-beck daniel-beck merged commit f0f6b1e into jenkinsci:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants