-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve presentation of plugin categories #4534
Conversation
- Show labels/categories in each plugin entry (supporting filtering) - Don't have multiple table sections for categories
One comment about UX, label display names should probably come from the update center: jenkins-infra/plugin-site-api#82 .Though it keeps a question about custom update centers then |
Seems orthogonal to this proposal. |
Could we get a little bit more spacing below the link and above the category? It looks too close to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
@@ -2454,6 +2457,7 @@ protected void replace(File dst, File src) throws IOException { | |||
} | |||
} | |||
|
|||
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Javadoc would with explanation be nice
@@ -989,7 +989,9 @@ private XmlFile getConfigFile() { | |||
/** | |||
* Returns a list of plugins that should be shown in the "available" tab, grouped by category. | |||
* A plugin with multiple categories will appear multiple times in the list. | |||
* @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @deprecated | |
* @deprecated No longer used for visualization in the Plugin Manager |
I plan to merge it tomorrow if no negative feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, the spacing really made a difference. It looks really nice!
@EstherAF Agreed, nobody should let me write UI. 😁 I'm glad @fqueiruga is around. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simple improvement!
The grouping into different table sections may have made sense when there were only 100 plugins total, but using the "Available" tab is basically limited to searching/filtering only now. So nobody really saw the categories anymore. While it is due for a larger overhaul, let's start with fixing how categories are shown.
It probably makes sense to add localizations for recently defined whitelisted labels in update-center2 to make it a rare occurrence to see an unlocalized label, but I think it's fine as is.
I'm open to alternative presentation/styling of the categories in the table entries, just propose alternatives.
Screenshots
Available list, filtered by label
Updates list
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate