[FIXED JENKINS-35270] Support loading js localization bundles from plugins #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @throws MissingResourceException when no bundle is found | ||
| */ | ||
| @Nonnull | ||
| public static JSONObject getBundle(String baseName) throws MissingResourceException { |
There was a problem hiding this comment.
IMHO the new methods should be Restricted as well.
Otherwise it cannot be considered for backporting
|
Would be great to see a direct unit test |
oleg-nenashev
added
needs-more-reviews
|
Test failure is related from what I see |
|
@kzantow Any plans to finalize the PR? |
Merged
8 tasks
|
@kzantow Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support loading js localization bundles from plugins.
Fixes: https://issues.jenkins-ci.org/browse/JENKINS-35270