-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace usages of
org.apache.commons.lang.StringEscapeUtils
with Gu…
…ava (#9094)
- Loading branch information
Showing
4 changed files
with
97 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
package jenkins.util; | ||
|
||
import com.google.common.escape.ArrayBasedCharEscaper; | ||
import com.google.common.escape.CharEscaper; | ||
import com.google.common.escape.Escaper; | ||
import java.util.Map; | ||
import org.kohsuke.accmod.Restricted; | ||
import org.kohsuke.accmod.restrictions.NoExternalUse; | ||
|
||
@Restricted(NoExternalUse.class) | ||
public final class SourceCodeEscapers { | ||
|
||
// Suppress default constructor for noninstantiability | ||
private SourceCodeEscapers() { | ||
throw new AssertionError(); | ||
} | ||
|
||
private static final Map<Character, String> REPLACEMENTS = Map.of( | ||
'\b', "\\b", | ||
'\f', "\\f", | ||
'\n', "\\n", | ||
'\r', "\\r", | ||
'\t', "\\t", | ||
'\"', "\\\"", | ||
'\\', "\\\\"); | ||
|
||
private static final char PRINTABLE_ASCII_MIN = 0x20; | ||
|
||
private static final char PRINTABLE_ASCII_MAX = 0x7E; | ||
|
||
private static final CharEscaper JAVA_CHAR_ESCAPER = new JavaCharEscaper(); | ||
|
||
/** | ||
* Returns an {@link Escaper} instance that escapes special characters in a string so it can | ||
* safely be included in either a Java character literal or string literal. | ||
*/ | ||
public static CharEscaper javaCharEscaper() { | ||
return JAVA_CHAR_ESCAPER; | ||
} | ||
|
||
private static class JavaCharEscaper extends ArrayBasedCharEscaper { | ||
JavaCharEscaper() { | ||
super(REPLACEMENTS, PRINTABLE_ASCII_MIN, PRINTABLE_ASCII_MAX); | ||
} | ||
|
||
@Override | ||
protected char[] escapeUnsafe(char c) { | ||
return String.format("\\u%04X", (int) c).toCharArray(); | ||
} | ||
} | ||
} |
42 changes: 42 additions & 0 deletions
42
core/src/test/java/jenkins/util/SourceCodeEscapersTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
package jenkins.util; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
import static org.junit.Assert.assertThrows; | ||
|
||
import org.junit.Test; | ||
|
||
public class SourceCodeEscapersTest { | ||
|
||
@Test | ||
public void testJavaCharEscaper() { | ||
assertThrows(NullPointerException.class, () -> SourceCodeEscapers.javaCharEscaper() | ||
.escape(null)); | ||
assertEquals("", SourceCodeEscapers.javaCharEscaper().escape("")); | ||
|
||
assertEquals("foo", SourceCodeEscapers.javaCharEscaper().escape("foo")); | ||
assertEquals("\\t", SourceCodeEscapers.javaCharEscaper().escape("\t")); | ||
assertEquals("\\\\", SourceCodeEscapers.javaCharEscaper().escape("\\")); | ||
assertEquals("'", SourceCodeEscapers.javaCharEscaper().escape("'")); | ||
assertEquals("\\\\\\b\\t\\r", SourceCodeEscapers.javaCharEscaper().escape("\\\b\t\r")); | ||
assertEquals("\\u1234", SourceCodeEscapers.javaCharEscaper().escape("\u1234")); | ||
assertEquals("\\u0234", SourceCodeEscapers.javaCharEscaper().escape("\u0234")); | ||
assertEquals("\\u00EF", SourceCodeEscapers.javaCharEscaper().escape("\u00ef")); | ||
assertEquals("\\u0001", SourceCodeEscapers.javaCharEscaper().escape("\u0001")); | ||
assertEquals("\\uABCD", SourceCodeEscapers.javaCharEscaper().escape("\uabcd")); | ||
|
||
assertEquals( | ||
"He didn't say, \\\"stop!\\\"", | ||
SourceCodeEscapers.javaCharEscaper().escape("He didn't say, \"stop!\"")); | ||
assertEquals( | ||
"This space is non-breaking:\\u00A0", | ||
SourceCodeEscapers.javaCharEscaper().escape("This space is non-breaking:\u00a0")); | ||
assertEquals( | ||
"\\uABCD\\u1234\\u012C", SourceCodeEscapers.javaCharEscaper().escape("\uABCD\u1234\u012C")); | ||
assertEquals( | ||
"\\uD83D\\uDC80\\uD83D\\uDD14", | ||
SourceCodeEscapers.javaCharEscaper().escape("\ud83d\udc80\ud83d\udd14")); | ||
assertEquals( | ||
"String with a slash (/) in it", | ||
SourceCodeEscapers.javaCharEscaper().escape("String with a slash (/) in it")); | ||
} | ||
} |