Limiting ProcessTree.killAll to InboundAgentRule.after
#802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jul 10, 2024
| private final ConcurrentMap<String, Process> procs = new ConcurrentHashMap<>(); | ||
| private final Map<String, Process> procs = Collections.synchronizedMap(new HashMap<>()); |
basil
approved these changes
Jul 10, 2024
Vlatombe
approved these changes
Jul 10, 2024
julieheard
approved these changes
Jul 10, 2024
basil
added a commit
to basil/plugin-compat-tester
that referenced
this pull request
Jul 10, 2024
basil
added a commit
to jenkinsci/plugin-compat-tester
that referenced
this pull request
Jul 10, 2024
|
Thank you very much! Confirming that my Jetty 12 test matrix is back to green after this PR. |
basil
added a commit
to basil/jenkins-test-harness
that referenced
this pull request
Jul 15, 2024
basil
added a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#795 (comment) I neglected to consider direct call to
InboundAgentRule.stopfrom test code, which should not kill subprocesses, only the agent JVM itself. Tested inworkflow-durable-task-stepon all test cases inAgentErrorConditionTest&ExecutorStepTest; also verified that the proprietary test suite originally motivating #795 continues to pass with this, and that subprocesses are still terminated at the end of the test.