This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Support round-tripping of servlet requests and responses #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10 broke the ability to round-trip servlet requests back and forth between wrapper objects. This PR restores this capability, at least for the main 4 types. I will think more about the naming of this and try to come up with a cleaner implementation that can be generalized to all types, but for now this restores the status quo prior to #10.
Testing done
hudson.plugins.sshslaves.verifiers.TrustHostKeyActionTest#testSubmitNotAuthorisedstarted failing after #10 and passes with this PR and the corresponding Stapler/core changes.